RFR: 8330814: Cleanups for KeepAliveCache tests [v2]
Christoph Langer
clanger at openjdk.org
Wed May 1 20:45:27 UTC 2024
On Tue, 30 Apr 2024 15:04:37 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> I've thought about this, too. However, I see the only critical point why it could merit a `/othervm` test is this thing with querying the thread CPU time of the Keep-Alive-SocketCleaner thread. But I think the likelihood of this failing is the same within standard test and `/othervm`. So I'd prefer to change to standard test, since this is one of the improvements of this change.
>
> The cache is global. Who knows what it might already contain when the test starts and what may be left behind when the test ends. So I agree that it may be prudent to keep `/othervm`
OK, then reverting back to `/othervm`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18884#discussion_r1586803001
More information about the net-dev
mailing list