RFR: 8331195: Improve com.sun.net.httpserver.HttpExchange usability [v4]
Ethan McCue
duke at openjdk.org
Fri May 3 13:19:55 UTC 2024
On Wed, 1 May 2024 21:12:05 GMT, robert engels <duke at openjdk.org> wrote:
>> improve the HttpExchange api with documented constants and convenience methods to avoid common bugs
>
> robert engels has updated the pull request incrementally with two additional commits since the last revision:
>
> - Merge remote-tracking branch 'robaho/HttpExchange-api-change' into HttpExchange-api-change
>
> # Conflicts:
> # src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java
> - update api changes based on comments
src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java line 82:
> 80: * @see #sendResponseHeaders(int, long)
> 81: * */
> 82: public static final long CHUNKED_CONTENT = 0L;
I feel a little uneasy about these constant names, if only because the parameter they are intended to be used for is called "`responseLength`"
"The response length is chunked content." Feels strange. Really you don't know the response length. Perhaps `responseLength` is what should change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18955#discussion_r1589190605
More information about the net-dev
mailing list