RFR: 8331334: com/sun/net/httpserver/HttpsParametersClientAuthTest.java fails in testServerNeedClientAuth(false) [v2]

[Jaikiran Pai]

On Tue, 7 May 2024 11:35:17 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   don't check for exception message (which can be localized)
>
> test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 226:
> 
>> 224:                         }
>> 225:                         // verify it failed due to right reason
>> 226:                         Throwable cause = ioe.getCause();
> 
> shouldn't we start with `cause = ioe` like before? Or was this done to make sure we only look at the nested exception on windows?

Hello Daniel, yes this is intentional - The change to start with `ioe.getCause()` was prompted due to the Windows check, but ultimately since we are only always interested in the underlying cause and not the top level `IOException`, this change is thus relevant for other OSes as well. I have run the tests to make sure it's only the underlying cause (and not the top level one) which has the correct expected exception that this test checks for.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19091#discussion_r1592337082