RFR: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator [v2]

[Nizar Benalla]

On Thu, 9 May 2024 12:15:03 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Declare `ServerAuthenticator.invoked` as volatile
>
> test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 100:
> 
>> 98: 
>> 99:     static class ServerAuthenticator extends BasicAuthenticator {
>> 100:         private static boolean invoked = false;
> 
> this should be declared volatile since it will be mutated in one thread and read in the other.

Fixed in [5003802](https://github.com/openjdk/jdk/pull/19133/commits/5003802b98c1fb3f19703c7c6c5b3aa2ce2bcbc6). I'll run the tests again.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19133#discussion_r1595400259