RFR: 8332015: Add `@since` tags to jdk.httpserver [v2]

Alan Bateman alanb at openjdk.org
Fri May 10 05:33:04 UTC 2024


On Fri, 10 May 2024 03:53:12 GMT, Nizar Benalla <duke at openjdk.org> wrote:

>> Please review this simple change, aiming to fix current uses of `@since` in the source code
>> -The constructor BasicAuthenticator(java.lang.String,java.nio.charset.Charset) needs an `@since 14` instead of 9.
>> -com.sun.net.httpserver.spi: package-info.java does not contain an `@since`.
>> Thanks in advance.
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix copyright headers

Marked as reviewed by alanb (Reviewer).

The HTTP server was added in JDK 6. The 2-arg constructor was added to BasicAuthenticator via JDK-8199849 in JDK 14. So I think this looks right.

-------------

PR Review: https://git.openjdk.org/jdk/pull/19168#pullrequestreview-2049278013
PR Comment: https://git.openjdk.org/jdk/pull/19168#issuecomment-2103897918


More information about the net-dev mailing list