RFR: 8332006: Test com/sun/net/httpserver/TcpNoDelayNotRequired.java run timeout with -Xcomp [v2]

Daniel Fuchs dfuchs at openjdk.org
Fri May 10 10:07:01 UTC 2024


On Fri, 10 May 2024 01:22:17 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi,
>>   The testcase TcpNoDelayNotRequired.java run timeout with -Xcomp jvm options. With -Xcomp jvm options, the jvm consumes a lot of time to compile the java code, but the timeout value is set to 5 second.
>> 
>>   I think it has 3 methods to solve this timeout issue.
>> 
>> 1. Change timeout value from 5 to 60 or more.
>> 2. Problemlist this testcase in `test/hotspot/jtreg/ProblemList-Xcomp.txt`
>> 3. Set this testcase `@requires vm.compMode != "Xcomp"`, so this testcase will be skiped when set jvm options -`Xcomp` or `-Xcomp -XX:TieredStopAtLevel=1`
>> 
>>   Maybe the 3rd method seems more reasonable.
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change "@requires vm.flagless" to "@requires vm.compMode != \"Xcomp\""

This looks like the right thing to do.

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19159#pullrequestreview-2049753832


More information about the net-dev mailing list