RFR: 8144100: Incorrect case-sensitive equality in com.sun.net.httpserver.BasicAuthenticator [v2]

[Nizar Benalla]

On Fri, 10 May 2024 09:46:44 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Declare `ServerAuthenticator.invoked` as volatile
>
> test/jdk/com/sun/net/httpserver/BasicAuthToken.java line 24:
> 
>> 22:  */
>> 23: 
>> 24: /**
> 
> Suggestion:
> 
> /*
> 
> It was recently suggested that test comments are not API documentation comments, and that we should avoid `/**` in that case. Maybe we will do a global pass on the test base at some point (or not) but in the mean time let's avoid propagating this pattern in new tests.

Maybe we can use a script to fix them all in one a large change, similar to #18268

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19133#discussion_r1596751704