RFR: 8332020: jwebserver tool prints invalid URL in case of IPv6 address binding [v3]

Vyom Tewari vtewari at openjdk.org
Fri May 10 14:42:14 UTC 2024


On Fri, 10 May 2024 12:02:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8332020?
>> 
>> `jwebserver` when it is launched prints a URL where the server is accessible. When launched using an IPv6 bind address, the printed URL doesn't enclose the IPv6 literal in `[` `]` thus rendering it in the form:
>> 
>> URL http://0:0:0:0:0:0:0:1:8000/
>> 
>> This is an incorrect representation. As noted in RFC-2732 https://www.rfc-editor.org/rfc/rfc2732#section-2, the host literal is expected to be enclosed between `[` and `]`. 
>> 
>> The commit in this PR addresses that issues. A new jtreg test has been introduced to reproduce this issue and verify the fix.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use -p 0 in the test
>   
>   Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>

Looks OK to me, please update the copyright for the 'SimpleFileServerImpl.java' before pushing.

-------------

Marked as reviewed by vtewari (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19173#pullrequestreview-2050231108


More information about the net-dev mailing list