RFR: 8329825: Clarify the value type for java.net.SocketOptions.SO_LINGER [v2]

Alan Bateman alanb at openjdk.org
Fri May 17 08:35:04 UTC 2024


On Fri, 17 May 2024 05:44:29 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this doc-only change which clarifies the value type for the `java.net.SocketOptions.SO_LINGER` option?
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   reword the javadoc

src/java.base/share/classes/java/net/SocketOptions.java line 197:

> 195:      * can be passed to {@link #setOption(int, Object)} to disable this option. An integer
> 196:      * value {@code >= 0} passed to {@code setOption(int, Object)} will enable the option and
> 197:      * the value will represent the linger timeout.

I think the wording could be improved a bit with "Set the value to Boolean.FALSE or an integer less than 0 with setOption to disable this option".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19243#discussion_r1604554069


More information about the net-dev mailing list