RFR: 8332181: Deprecate for removal the java.net.MulticastSocket.setTTL/getTTL and the 2-arg send methods

Daniel Fuchs dfuchs at openjdk.org
Fri May 17 11:12:02 UTC 2024


On Wed, 15 May 2024 04:20:09 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to deprecate for removal 3 methods on `java.net.MulticastSocket`? This addresses https://bugs.openjdk.org/browse/JDK-8332181.
> 
> As noted in that issue these methods have been deprecated since Java 1.2 and 1.4 days. They currently have replacement methods (noted in their javadoc) which have been in use for several releases. This commit updates these deprecated methods to deprecated for removal, to allow for their removal in a future release.
> 
> No new tests have been added and existing tests in tier1, tier2 and tier3 continue to pass.

src/java.base/share/classes/java/net/NetMulticastSocket.java line 655:

> 653:     @Deprecated
> 654:     @Override
> 655:     @SuppressWarnings("removal")

Instead of adding `@SuppressWarning("removal")` here (and at other places below) - would it make sense to update the `@Deprecated` annotation and add `forRemoval = true`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19242#discussion_r1604784917


More information about the net-dev mailing list