RFR: 8343442: Add since checker tests to the networking area modules [v2]

Jaikiran Pai jpai at openjdk.org
Sat Nov 2 10:37:28 UTC 2024


On Fri, 1 Nov 2024 22:34:46 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:

>> Can I please get a review for this patch that brings the `@since` test described [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) to the networking area modules.
>> 
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation).
>> 
>> The test has been added for `java.base` 2 weeks ago and has helped catch some bugs before they make it to the JDK.
>> 
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   make jtreg comment more concise

Hello Nizar, is the use of underscores in the directory and file names intentional? For example:

> test/jdk/tools/sincechecker/modules/java_net_http/CheckSince_javaNetHttp.java

Would the since checker still work fine if that file was named something like:

> test/jdk/tools/sincechecker/modules/java/net/http/CheckSince.java

or even:

> test/jdk/tools/sincechecker/modules/java.net.http/CheckSince.java

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21838#issuecomment-2452948397


More information about the net-dev mailing list