RFR: 8343442: Add since checker tests to the networking area modules [v3]
Daniel Fuchs
dfuchs at openjdk.org
Tue Nov 5 15:50:33 UTC 2024
On Mon, 4 Nov 2024 18:28:00 GMT, Nizar Benalla <nbenalla at openjdk.org> wrote:
>> Can I please get a review for this patch that brings the `@since` test described [here](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html) to the networking area modules.
>>
>> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation).
>>
>> The test has been added for `java.base` 2 weeks ago and has helped catch some bugs before they make it to the JDK.
>>
>> Note: the `@modules` declarations are missing from the jtreg comment because we will now include them in a `TEST.properties` file.
>>
>> TIA
>
> Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
>
> Rename tests and directories under modules dir
Marked as reviewed by dfuchs (Reviewer).
Ok thanks for the clarification. LGTM then.
I guess some of these tests will have to be temporarilly problem listed on project/branches where the target JDK is not know yet known? Typically I'm used to add
* @since TBD
when adding new APIs in such cases. I guess that would trip this test now.
-------------
PR Review: https://git.openjdk.org/jdk/pull/21838#pullrequestreview-2416026272
PR Comment: https://git.openjdk.org/jdk/pull/21838#issuecomment-2457530518
More information about the net-dev
mailing list