RFR: 8343855: HTTP/2 ConnectionWindowUpdateSender may miss some unprocessed DataFrames from closed streams [v3]

Jaikiran Pai jpai at openjdk.org
Wed Nov 13 10:43:16 UTC 2024


On Wed, 13 Nov 2024 10:38:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test/jdk/java/net/httpclient/http2/StreamFlowControlTest.java
>>   
>>   Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
>
> test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java line 434:
> 
>> 432:      * The response is always returned with fixed length.
>> 433:      */
>> 434:     public static class HttpHeadHandler implements HttpTestHandler {
> 
> The class name is slightly misleading since this also handles `GET`. Perhaps `HeadOrGetHandler` would be appropriate?

And maybe we should make this a top level public class in this test package to reduce the amount of code we have in the `HttpServerAdapters` file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21991#discussion_r1839951144


More information about the net-dev mailing list