RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5

[Daniel Fuchs]

On Mon, 11 Nov 2024 08:59:03 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

> This PR introduces the following changes addressing intermittent `PlainProxyConnectionTest` failures reported in [JDK-8342811](https://bugs.openjdk.org/browse/JDK-8342811):
> 
> * Increase logging verbosity to aid in troubleshooting (if the failure happens to pop up again)
> * Add salt to the used HTTP server path to decrease the chances of parallel running tests from interfering

test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 56:

> 54: /**
> 55:  * @test
> 56:  * @bug 8230526 8342811

We only list there bugs for which a change was made under /src and which the test can verify. 
We don't list bugids for which there was only test code changes. In that case we instead add the `noreg-self` label to the JBS issue.

test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 60:

> 58:  *          verifying that the remote address of the HTTP exchange (on the fake proxy server)
> 59:  *          is always the same InetSocketAddress. Logging verbosity is increased to aid in
> 60:  *          diagnosis of intermittent failures reported in 8342811.

Not a big deal but there's no need to add that to the test summary.

test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 67:

> 65:  *      -Djdk.internal.httpclient.debug=true
> 66:  *      PlainProxyConnectionTest
> 67:  * @author danielfuchs

Suggestion:



You can remove that `@author` tag.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22003#discussion_r1842425259
PR Review Comment: https://git.openjdk.org/jdk/pull/22003#discussion_r1842427305
PR Review Comment: https://git.openjdk.org/jdk/pull/22003#discussion_r1842429233