RFR: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration

Daniel Fuchs dfuchs at openjdk.org
Fri Nov 15 09:53:37 UTC 2024


On Fri, 15 Nov 2024 07:56:15 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this PR which removes SM permission checking from `s.n.w.p.j.JarFileFactory`.
> 
> This removes the permission checking happening in `JarFileFactory::getCachedJarFile` and also removes the associated private `getPermission` method, (sadly including the cute `// gulp`). The import of `java.security.Permission` is also removed.
> 
> Testing: `test/jdk/sun/net/www/protocol/jar` runs green, GHA results pending.

Changes look good, but since this is linked to JarURLConnection it would be good to run tier1,tier2 to validate.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22135#issuecomment-2478387503


More information about the net-dev mailing list