RFR: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration

Daniel Fuchs dfuchs at openjdk.org
Fri Nov 15 10:01:10 UTC 2024


On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this JEP486 cleanup PR in the `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
> 
> * The `MailToURLConnection::getPermission` override with the related `permission` field is removed
> * The SM property access check in `MailToURLConnection::getFromAddress` is removed
> * The `SmtpClient` use of `GetPropertyAction` is replaced with plain `System::getProperty`
> 
> As a side note I have been programming Java since 1998 and I was not aware that this very limited (untested?) mechanism for sending email existed in the JDK. Unless it is in extensive use, perhaps we should consider deprecating it somehow. Superior alternatives exist.

Changes look reasonable. Please run tier2 to validate.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22138#pullrequestreview-2438179112


More information about the net-dev mailing list