RFR: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5 [v3]

Daniel Fuchs dfuchs at openjdk.org
Fri Nov 15 10:07:28 UTC 2024


On Fri, 15 Nov 2024 08:51:48 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> test/jdk/java/net/httpclient/PlainProxyConnectionTest.java line 60:
>> 
>>> 58:  *          verifying that the remote address of the HTTP exchange (on the fake proxy server)
>>> 59:  *          is always the same InetSocketAddress. Logging verbosity is increased to aid in
>>> 60:  *          diagnosis of intermittent failures reported in 8342811.
>> 
>> Not a big deal but there's no need to add that to the test summary.
>
> Removed in 8cec4a7769f71dc0ca44e8c9e0bbfadcb0531927. (I had kept it around so that if the issue pops up again and we figure out how to fix it, we will have a handle to go to the ticket and resolve it. But there are other, maybe better, ways to do this, I guess.)

What I meant is that there was no need to modify the test summary to explain that logging has been enabled. I mean the test summary is there to explain what the test is trying to verify. Its not a changelog ;-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22003#discussion_r1843526947


More information about the net-dev mailing list