RFR: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration [v3]

[Daniel Fuchs]

On Fri, 15 Nov 2024 13:15:42 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into HttpClient-SM-8344228
>>  - Review feedback
>>  - 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
>
> src/java.net.http/share/classes/jdk/internal/net/http/ResponseBodyHandlers.java line 55:
> 
>> 53:     private ResponseBodyHandlers() { }
>> 54: 
>> 55:     private static final String checkPathForDefaultFS(Path path) {
> 
> Nit - we could probably inline the implementation of this method at the one single call site where this gets called. That way it's a bit more clear what this method is for.
> 
> Same comment for the same named method in one other class.

Done.

> src/java.net.http/share/classes/jdk/internal/net/http/ResponseSubscribers.java line 186:
> 
>> 184:         }
>> 185: 
>> 186:         private static boolean isDefaultFS(Path file) {
> 
> Is this method used anymore or can it be removed?

Good point. Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22118#discussion_r1843852434
PR Review Comment: https://git.openjdk.org/jdk/pull/22118#discussion_r1843851857