RFR: 8344315: Clean up sun.net.www.protocol.jrt.JavaRuntimeURLConnection after JEP 486 integration
Daniel Fuchs
dfuchs at openjdk.org
Fri Nov 15 16:44:44 UTC 2024
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which removes references to `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the implementation.
> - The overridden `getPermission()` method has been removed from this internal implementation class.
> - The call to `URLClassPath.checkURL()` which used to invoke a SecurityManager check in the presence of a SecurityManager has been removed.
>
> No new test has been introduced and tier1 and tier2 testing is currently in progress.
LGTM. Would be good to have @AlanBateman review too.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22151#pullrequestreview-2439136842
More information about the net-dev
mailing list