Integrated: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration

Eirik Bjørsnøs eirbjo at openjdk.org
Fri Nov 15 19:25:52 UTC 2024


On Fri, 15 Nov 2024 08:28:44 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this JEP486 cleanup PR in the `s.n.w.p.mailto.MailToURLConnection` and `sun.net.smtp.SmtpClient` classes.
> 
> * The `MailToURLConnection::getPermission` override with the related `permission` field is removed
> * The SM property access check in `MailToURLConnection::getFromAddress` is removed
> * The `SmtpClient` use of `GetPropertyAction` is replaced with plain `System::getProperty`
> 
> As a side note I have been programming Java since 1998 and I was not aware that this very limited (untested?) mechanism for sending email existed in the JDK. Unless it is in extensive use, perhaps we should consider deprecating it somehow. Superior alternatives exist.

This pull request has now been integrated.

Changeset: f3168082
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f3168082b809dfe39afdf7064a83e7a39a1d3094
Stats:     24 lines in 2 files changed: 0 ins; 20 del; 4 mod

8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/22138


More information about the net-dev mailing list