RFR: 8344315: Clean up sun.net.www.protocol.jrt.JavaRuntimeURLConnection after JEP 486 integration
Jaikiran Pai
jpai at openjdk.org
Sat Nov 16 01:26:31 UTC 2024
On Fri, 15 Nov 2024 15:55:57 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which removes references to `AccessController.doPriveleged()` and also removes a security check?
>
> Specifically:
>
> - The `AccessController.doPriveleged()` has been removed from the implementation.
> - The overridden `getPermission()` method has been removed from this internal implementation class.
> - The call to `URLClassPath.checkURL()` which used to invoke a SecurityManager check in the presence of a SecurityManager has been removed.
>
> No new test has been introduced and tier1 and tier2 testing is currently in progress.
Thank you Alan and Daniel for the reviews. tier1 and tier2 testing came back fine.
There's one unrelated failure in this PR's GitHub actions job in `GetStackTraceALotWhenBlocking` which has timed out. I will check to see if a separate issue needs to be created to track that.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22151#issuecomment-2480262413
More information about the net-dev
mailing list