Integrated: 8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration

[Jaikiran Pai]

On Fri, 15 Nov 2024 10:31:11 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which removes calls to `SecurityManager` and `AccessController.doPrivileged()` from the `ProxySelector` and `DefaultProxySelector` classes?
> 
> Apart from the trivial removing of those calls, the commit in this PR also removes the `getProxySelector` and `setProxySelector` named `NetPermission`s. These 2 named permissions, were previously only documented on the `ProxySelector.getDefault()` and `ProxySelector.setDefault()` methods. With the removal of SecurityManager, the specification of these named properties ceases to exist. Having said that, would removal of these named NetPermission(s) require a CSR linked to this current issue?
> 
> The other major chunk of this change is moving the proxy determination logic in `DefaultProxySelector` into a private method from the previous `doPriveleged()` call block.
> 
> No new tests have been introduced. Existing tests in tier1 and tier2 continue to pass with this change.

This pull request has now been integrated.

Changeset: a91d4c02
Author:    Jaikiran Pai <jpai at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/a91d4c022f1ccaec68d7e3ce21be402ffc568eca
Stats:     233 lines in 4 files changed: 74 ins; 123 del; 36 mod

8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration

Reviewed-by: dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/22145