[RFD] Stray permission comment in sun.net.www.protocol.jar.JarURLConnection

[Eirik Bjørsnøs]

Hi,

At the end of s.n.w.p.j.JarURLConnection::connect, I see this stray,
permission related comment:

/* we also ask the factory the permission that was required
>  * to get the jarFile, and set it as our permission.
>  */
> if (useCaches) {
>     boolean oldUseCaches = jarFileURLConnection.getUseCaches();
>     jarFileURLConnection = factory.getConnection(jarFile);
>     jarFileURLConnection.setUseCaches(oldUseCaches);
> }


The "factory" here is JarFileFactory, which recently went through a
SM-cleanup PR which removed permission checking.

The comment seems to have existed since the initial load, but have moved
around a bit since then.

It does not seem to make a lot of sense now, and digging through history
I'm also struggling a bit to understand how it made sense even in the
initial load.

What's the best action here? Delete the comment? Replace it with something
more appropriate? Wait for pending JEP486 cleanup to take care of it?

Thanks,
Eirik.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/net-dev/attachments/20241120/14f8213b/attachment.htm>