RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v12]

[Mark Sheppard]

On Thu, 21 Nov 2024 10:47:54 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Handle `SocketTimeoutException` in `NioSocketImpl::connect()`

test/jdk/java/net/Socket/CloseOnFailureTest.java line 128:

> 126:     @MethodSource("ctor_should_close_on_failures")
> 127:     @SuppressWarnings("resource")
> 128:     void ctor_should_close_on_failures(TestCase testCase) throws Throwable {

Is the style convention for  Java code  to use camel case for all classes, methods and variables ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1852956264