RFR: 8344219: Remove calls to SecurityManager and doPrivileged in java.net.SocksSocketImpl after JEP 486 integration [v3]
Volkan Yazıcı
duke at openjdk.org
Fri Nov 22 08:44:55 UTC 2024
On Thu, 21 Nov 2024 16:16:44 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Revert to using a synchronized method to perform the connection
>
> src/java.base/share/classes/java/net/SocksSocketImpl.java line 246:
>
>> 244: // server is not null only when the socket was created with a
>> 245: // specified proxy in which case it does bypass the ProxySelector
>> 246: @SuppressWarnings("removal")
>
> Suggestion:
>
>
> Redundant suppression.
Thanks @liach! 🙏
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22271#discussion_r1853504163
More information about the net-dev
mailing list