RFR: 8344217: Remove calls to SecurityManager and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration [v2]

[Daniel Fuchs]

On Fri, 22 Nov 2024 07:48:04 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Simplify wording in DatagramSocket::connect
>>  - Merge branch 'master' into DS-SM-8344217
>>  - 8344217: Remove calls to SecurityManager and and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration
>
> src/java.base/share/classes/java/net/DatagramSocket.java line 391:
> 
>> 389:      *
>> 390:      * <p> When a socket is connected, additional checks are performed
>> 391:      * on a send operation: if the packet's address is set and the packet's address
> 
> Yes, an oversight that the "Care should be taken ..." wasn't removed as part of JEP 486.
> 
> Opinions may differ but I think it may be simpler to remove this sentence completely rather than re-word it. The right place to specify that send may throw IAE is in the send method description and is already does this.
> 
> If you do want to keep something it could be reduced down to: "When the socket is connected, the send method checks that the packet's address matches the remote address that the socket is connected to", no need to say anything about IAE.

Thanks Alan. Done. I have also updated the CSR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22303#discussion_r1853741603