RFR: 8343150: Change URLClassLoader.getPermissions to return empty PermissionCollection [v3]

Jaikiran Pai jpai at openjdk.org
Fri Nov 22 11:21:35 UTC 2024


On Fri, 22 Nov 2024 11:04:35 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which removes the `getPermissions()` method from the `URLClassLoader`? This addresses https://bugs.openjdk.org/browse/JDK-8343150.
>> 
>> With the SecurityManager implementation removed through JEP 486, this method of the `URLClassLoader` is no longer relevant.
>> 
>> No new tests have been added. tier1 and tier2 testing is currently in progress.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - specify URLClassLoader to reutrn empty PermissionCollection
>  - merge latest from master branch
>  - Revert "update the specification of java.security.SecureClassLoader.getPermissions()"
>    
>    This reverts commit d6220b19a0c4b54d8fc879302baacfa90075f47f.
>  - update the specification of java.security.SecureClassLoader.getPermissions()
>  - merge latest from master branch
>  - 8343150: Remove URLClassLoader.getPermissions after JEP 486 integration

After further discussions between Alan, Sean and me, we decided to retain the `getPermissions()` method on the `URLClassLoader` and instead respecify it to return an empty `PermissionCollection`. The CSR and the PR has been updated accordingly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22179#issuecomment-2493517502


More information about the net-dev mailing list