RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v16]

[Daniel Fuchs]

On Tue, 26 Nov 2024 09:05:47 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 23 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into Socket-CloseOnFailure-8343791
>  - Add tests using real sockets
>  - Add tests with real sockets
>  - Relax assertion to fix failing `IDNTest`
>  - Merge remote-tracking branch 'upstream/master' into Socket-CloseOnFailure-8343791
>  - Reflect behavioral changes to `SocketAdaptor`
>  - Improve variable names
>  - Improve naming in tests
>  - Handle `SocketTimeoutException` in `NioSocketImpl::connect()`
>  - Revert `UHE` message change in `NioSocketImpl`
>  - ... and 13 more: https://git.openjdk.org/jdk/compare/9793e73b...e0fb7061

The Mock implementation also has the advantage that you don't need to create a real socket - so you can use any port / address you want since no real socket is bound/connected with those parameters.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22160#issuecomment-2500257133