RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v17]

Volkan Yazıcı duke at openjdk.org
Wed Nov 27 11:53:02 UTC 2024


On Wed, 27 Nov 2024 10:47:17 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Split tests into multiple files
>
> src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java line 93:
> 
>> 91:                     throw new SocketException("Socket is closed");
>> 92:             if (sc.isConnected())
>> 93:                     throw new SocketException("Already connected");
> 
> Would you mind changing this to use 4-space instead of 8-space indent?

Fixed in aaf398f328cfb4771df1a7af22090c5117ec6055.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1860524148


More information about the net-dev mailing list