RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v19]
Volkan Yazıcı
duke at openjdk.org
Wed Nov 27 14:34:32 UTC 2024
> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>
> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:
- Replace complex JUnit machinery with native Java
- Remove tests using mocks
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22160/files
- new: https://git.openjdk.org/jdk/pull/22160/files/aaf398f3..94543642
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22160&range=18
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22160&range=17-18
Stats: 1112 lines in 9 files changed: 360 ins; 752 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/22160.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22160/head:pull/22160
PR: https://git.openjdk.org/jdk/pull/22160
More information about the net-dev
mailing list