RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v22]

[Alan Bateman]

On Thu, 28 Nov 2024 09:12:58 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>> 
>> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
>
> Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Don't exceed 120 characters per line
>  - Rework functional interfaces in tests

I did a pass over the latest tests, it's improved a lot. One general comment is that I'm surprised to see 4 method sources, this test only needs one to yield two newly created Sockets. The benefit of doing that it that the setup will be in the tests so much easier to diagnose if we get a test failure. I'm sure Daniel will have comments but I think overall this is getting close to the finish line.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22160#issuecomment-2506269405