RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v22]

[Daniel Fuchs]

On Thu, 28 Nov 2024 14:24:02 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Don't exceed 120 characters per line
>>  - Rework functional interfaces in tests
>
> test/jdk/java/net/Socket/ConnectFailTest.java line 105:
> 
>> 103:                 ConnectFailTest::createConnectedNioSocket,
>> 104:                 executable -> assertThrows(AlreadyConnectedException.class, executable));
>> 105:     }
> 
> I assume that testConnectedSocket and testConnectedNioSocket could be @ParameterizedTest so it's called with a new created Socket.

It would make them similar to the other test method but would be a bit strange since the test method would be called only once with a single parameter set.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1862376904