RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v22]
Volkan Yazıcı
duke at openjdk.org
Thu Nov 28 16:12:40 UTC 2024
On Thu, 28 Nov 2024 16:06:00 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:
>>> I will push an enhancement here. Allow me some time, please.
>>
>> That's fine, it seems we have lacked good tests for these exceptional cases so probably not surprising that some issues turn up.
>
> For the record, `Net::translateToSocketException` doesn't map `AlreadyConnectedException`.
> I checked the socket adaptor and there is needed a bug here. SocketChannel throws AlreadyConnectedException and the socket adaptor should map that to SocketException("already connected"). It doesn't do that so we should fix it.
@AlanBateman, I presume you want me to fix that mapping in a separate JBS+PR, right?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1862443621
More information about the net-dev
mailing list