RFR: 8345223: Remove doPrivileged in java.base/unix/classes/sun/net and java.base/macosx/classes/java/net classes after JEP 486 integration [v2]
Volkan Yazıcı
duke at openjdk.org
Fri Nov 29 08:44:38 UTC 2024
On Thu, 28 Nov 2024 20:11:15 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Some doPrivileged were missed in some net classes when working on previous cleanups.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>
> Update Copyright Years
src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java line 87:
> 85: defaultDomain = props.getProperty("http.auth.ntlm.domain", "");
> 86: String ntlmCacheProp = props.getProperty("jdk.ntlm.cache", "true");
> 87: ntlmCache = Boolean.parseBoolean(ntlmCacheProp);
Can't these simply be replaced with `System.getProperty()`? (There are more usages of `privilegedGetProperties()` in this file, FYI.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22447#discussion_r1863149993
More information about the net-dev
mailing list