RFR: 8345176: Add tests to verify java.net.Socket constructors close the socket on failure [v2]

[Volkan Yazıcı]

On Thu, 28 Nov 2024 17:01:32 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazıcı has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Further simplify the test
>
> test/jdk/java/net/Socket/CtorFailTest.java line 108:
> 
>> 106: 
>> 107:     static List<Arguments> testCases() {
>> 108:         String exceptionMessage = "intentional test failure";
> 
> It would be good to put a comment here to remind the reader what the first argument is and what the second argument is. Something like:
> 
> 
>         // Arguments: Exception bindException, Exception connectException

Switched from using (untyped) `Arguments` to `MockSocketImpl` in 5e492b7bb83c6668f31d3e72aa6ce458221ee846.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22439#discussion_r1863220981