RFR: 8235786: Javadoc for com/sun/net/httpserver/HttpExchange.java#setAttribute is unclear [v2]

Jaikiran Pai jpai at openjdk.org
Fri Nov 29 12:44:16 UTC 2024


> Can I please get a review of this doc-only change which proposes to clarify the behaviour of `com.sun.net.httpserver.HttpExchange.setAttribute()` and `com.sun.net.httpserver.HttpExchange.getAttribute()` methods?
> 
> As noted in https://bugs.openjdk.org/browse/JDK-8235786, it's not clear from the javadoc of these methods that the attributes that are set or retrieved through the exchange are actually those that belong to the entire `com.sun.net.httpserver.HttpContext` and thus are shared by all exchanges.
> 
> The commit in this PR specifies this behaviour to match the current implementation. I'll file a CSR once we settle on the text.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  Michael's suggestion - shorten the "@return"

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22454/files
  - new: https://git.openjdk.org/jdk/pull/22454/files/e5837da7..6628c51d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22454&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22454&range=00-01

  Stats: 5 lines in 1 file changed: 2 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/22454.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22454/head:pull/22454

PR: https://git.openjdk.org/jdk/pull/22454


More information about the net-dev mailing list