RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v26]
Volkan Yazıcı
duke at openjdk.org
Fri Nov 29 15:29:06 UTC 2024
> This PR, addressing 8343791, changes `Socket::connect()` methods to close the `Socket` in the event that the connection cannot be established, the timeout expires before the connection is established, or the socket address is unresolved.
>
> `tier3` tests pass against the 9f00f61d3b7fa42a5e23a04f80bb4bb1a2076ef2.
Volkan Yazıcı has updated the pull request incrementally with two additional commits since the last revision:
- Improve Javadoc
- Match `UHE` message in `Socket` and `SocketImpl`
This discrepancy was causing following tests to fail:
- javax/xml/jaxp/unittest/common/dtd/DOMTest.java
- javax/xml/jaxp/unittest/common/dtd/SAXTest.java
- javax/xml/jaxp/unittest/common/catalog/SAXTest.java
- javax/xml/jaxp/unittest/common/catalog/DOMTest.java
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22160/files
- new: https://git.openjdk.org/jdk/pull/22160/files/b6a2c8c9..d69d14c2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22160&range=25
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22160&range=24-25
Stats: 7 lines in 2 files changed: 0 ins; 0 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/22160.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22160/head:pull/22160
PR: https://git.openjdk.org/jdk/pull/22160
More information about the net-dev
mailing list