RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v3]
Jaikiran Pai
jpai at openjdk.org
Wed Oct 23 13:03:09 UTC 2024
On Tue, 22 Oct 2024 15:08:57 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here a fix that improves flow control in the HTTP/2 implementation.
>>
>> The change makes sure that flow control issues are reported to the server as FLOW_CONTROL_ERROR.
>> It also clarify how some system properties that allow to initialize flow control windows are handled, by documenting the full range of valid values (when applicable) and explaining what happens if the property points to a value that is out of range.
>>
>> Bad flow control values in the SETTINGS frame will also cause a FLOW_CONTROL_ERROR to be reported.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>
> Integrated review feedback
Thank you for the updates Daniel. This looks good to me.
-------------
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21567#pullrequestreview-2388600379
More information about the net-dev
mailing list