RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v3]

Alan Bateman alanb at openjdk.org
Mon Sep 2 18:42:19 UTC 2024


On Mon, 2 Sep 2024 17:44:31 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here a change that adds a few `@apiNote` and `@implNote` to `NetworkInterface` to clarify user expectation and implementation.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve class level description again

src/java.base/share/classes/java/net/NetworkInterface.java line 120:

> 118:      * The returned array contains all or a subset of the InetAddresses that were
> 119:      * bound to the interface at the time the {@linkplain #getNetworkInterfaces()
> 120:      * interface configuration was read}

I think you have a typo here in that this method returns an Enumeration rather than an array.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20822#discussion_r1741195094


More information about the net-dev mailing list