RFR: 8338740: java/net/httpclient/HttpsTunnelAuthTest.java fails with java.io.IOException: HTTP/1.1 header parser received no bytes [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Sep 3 11:08:49 UTC 2024


On Tue, 3 Sep 2024 06:48:38 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> test/jdk/java/net/httpclient/ProxyServer.java line 199:
> 
>> 197: 
>> 198:         volatile boolean proxyInClosed;
>> 199:         volatile boolean proxyOutClosed;
> 
> nit: these variables don't need to be volatile; they are only accessed in a synchronized block

Good point

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20674#discussion_r1741864420


More information about the net-dev mailing list