RFR: 8283779: Clarify API documentation of NetworkInterface with respect to configuration changes [v11]
Daniel Fuchs
dfuchs at openjdk.org
Mon Sep 9 13:40:44 UTC 2024
On Mon, 9 Sep 2024 10:37:44 GMT, Mark Sheppard <msheppar at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback from CSR review
>
> src/java.base/share/classes/java/net/NetworkInterface.java line 64:
>
>> 62: * Network interface instances are typically used to identify the local
>> 63: * interface on which a multicast group is joined.
>> 64: *
>
> Several static methods in this class are factory methods, returning a new instance of a NetworkInterface, reflecting the configuration at the time of instantiation. The network configuration may change at any time, for example DCHP lease renewal , or IPv6 aoutconfig. As such, these methods may need to be invoked again, to obtain a more up-to-date view of the network interfaces.
Factory methods sounds good. Not sure we want to list what could cause the configuration to change: for virtual interfaces created by software components it could be just anything. I'll borrow part of your text and update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20822#discussion_r1750281169
More information about the net-dev
mailing list