RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v4]

Volkan Yazici vyazici at openjdk.org
Tue Apr 1 19:11:04 UTC 2025


On Thu, 27 Mar 2025 13:02:38 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve JavaDoc
>
> src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java line 103:
> 
>> 101:      * </p>
>> 102:      */
>> 103:     final String label;
> 
> I think this should be `private`.

Fixed in 883135d8edc2f2a892152e42eda924d65686bc7a.

> src/java.net.http/share/classes/jdk/internal/net/http/HttpResponseImpl.java line 44:
> 
>> 42:  * The implementation class for HttpResponse
>> 43:  */
>> 44: class HttpResponseImpl<T> implements HttpResponse<T>, RawChannel.Provider {
> 
> The copyright year on this file will need an update.

Fixed in 883135d8edc2f2a892152e42eda924d65686bc7a.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2023531901
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2023531280


More information about the net-dev mailing list