RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v6]
Daniel Fuchs
dfuchs at openjdk.org
Fri Apr 4 12:58:06 UTC 2025
On Fri, 4 Apr 2025 12:47:19 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Adds `HttpResponse::connectionLabel` method that provides an identifier for the connection.
>>
>> **Implementation note:** The feature is facilitated by `HttpConnection::label`, which should not be confused with `HttpConnection::id`. This distinction is explained in the JavaDoc of both properties.
>
> Volkan Yazici has updated the pull request incrementally with five additional commits since the last revision:
>
> - Remove timeout from `CountDownLatch::await` calls
> - Replace `@AutoClose` with a corresponding `@AfterEach` method
> - Remove IDE-specific `OptionalGetWithoutIsPresent` warning suppression
> - Improve `HttpConnection::label` JavaDoc
> - Start from 1 while labeling connections
New changes look good to me.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24154#pullrequestreview-2742914834
More information about the net-dev
mailing list