RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v7]

Jaikiran Pai jpai at openjdk.org
Mon Apr 7 07:48:05 UTC 2025


On Mon, 7 Apr 2025 07:43:28 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Adds `HttpResponse::connectionLabel` method that provides an identifier for the connection.
>> 
>> **Implementation note:** The feature is facilitated by `HttpConnection::label`, which should not be confused with `HttpConnection::id`. This distinction is explained in the JavaDoc of both properties.
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use `othervm` in `@run`

test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 35:

> 33: 
> 34: // `othervm` in `@run` is intentionally introduced, don't remove it!
> 35: // It helps with, in case `ForkJoinPool.commonPool()` gets corrupt by the test, reusing it again.

jtreg allows for `@comment` tag in the test definition. So you could replace this newly added code comment with something like:

@comment othervm usage is intentional since this test uses ForkJoinPool.commonPool()


just before the `@run ....` line in the test definition

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030640583


More information about the net-dev mailing list