RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v6]

Volkan Yazici vyazici at openjdk.org
Mon Apr 7 08:06:18 UTC 2025


On Fri, 4 Apr 2025 15:02:21 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with five additional commits since the last revision:
>> 
>>  - Remove timeout from `CountDownLatch::await` calls
>>  - Replace `@AutoClose` with a corresponding `@AfterEach` method
>>  - Remove IDE-specific `OptionalGetWithoutIsPresent` warning suppression
>>  - Improve `HttpConnection::label` JavaDoc
>>  - Start from 1 while labeling connections
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 173:
> 
>> 171:                                         serverId, connectionKey, responseBody);
>> 172:                                 ioe.printStackTrace(System.out);
>> 173:                             }
> 
> Shouldn't we be rethrowing these exceptions from the handler to fail the request?

In 4db85c315f698c18a77545d5a2e732edf3199292, removed the `synchronized { ... }` and re-threw the exception.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030677048


More information about the net-dev mailing list