RFR: 8350279: HttpClient: Add a new HttpResponse method to identify connections [v10]
Volkan Yazici
vyazici at openjdk.org
Mon Apr 7 09:31:49 UTC 2025
On Mon, 7 Apr 2025 09:08:17 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add -Djdk.httpclient.keepalive.timeout=120` to `@run`
>
> test/jdk/java/net/httpclient/HttpResponseConnectionLabelTest.java line 33:
>
>> 31: *
>> 32: * @comment `othervm` usage is intentional since this test uses `ForkJoinPool.commonPool()`
>> 33: * @comment There is no guarantee that sequential requests will be executed immediately one after the other.
>
> Thank you for all the updates so far Volkan. This is overall looking good to me. One final nit about this comment. I think we can leave out a lot of this text and just state something like:
>
>
> @comment use a higher idle timeout to increase the chances of
> the same connection being used for sequential HTTP requests
Simplified as suggested in db61a01542ce12496721857bb8581683bff2cf81.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24154#discussion_r2030847366
More information about the net-dev
mailing list