RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v2]

[Daniel Fuchs]

On Wed, 9 Apr 2025 13:36:23 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Overhauls `EmptyAuthenticate` to
>> 
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related problems
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply review suggestions

test/jdk/java/net/httpclient/EmptyAuthenticate.java line 75:

> 73:     void test(Version version, boolean secure) throws Exception {
> 74:         String uriPath = "/%s/%s/%s".formatted(EmptyAuthenticate.class.getSimpleName(), version, secure ? 's' : 'c');
> 75:         HttpTestServer server = createServer(version, secure, uriPath);

It's  actually better practice to have uri looks like "/rootpath/morechars" and register the handler for "/rootpath/"
=> make sure the path you pass to addHandler ends with "/". 

Suggestion:

        String handlerPath = "/%s/%s/".formatted(EmptyAuthenticate.class.getSimpleName(), version)
        String uriPath = handlerPath + (secure ? 's' : 'c');
        HttpTestServer server = createServer(version, secure, handlerPath);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24542#discussion_r2035482362