RFR: 8352431: java/net/httpclient/EmptyAuthenticate.java uses "localhost" [v3]

Daniel Fuchs dfuchs at openjdk.org
Wed Apr 9 14:50:32 UTC 2025


On Wed, 9 Apr 2025 14:35:30 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Overhauls `EmptyAuthenticate` to
>> 
>> - Test all supported HTTP versions (i.e., HTTP/1.1 and HTTP/2)
>> - Test both clear-text and SSL
>> - Use `HttpServerAdapters.HttpTestServer::create` to avoid host-related problems
>
> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve handler path
>   
>   Co-authored-by: Daniel Fuchs <67001856+dfuch at users.noreply.github.com>

test/jdk/java/net/httpclient/EmptyAuthenticate.java line 74:

> 72:     @MethodSource("args")
> 73:     void test(Version version, boolean secure) throws Exception {
> 74:         String handlerPath = "/%s/%s/".formatted(EmptyAuthenticate.class.getSimpleName(), version)

(D'oh)
Suggestion:

        String handlerPath = "/%s/%s/".formatted(EmptyAuthenticate.class.getSimpleName(), version);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24542#discussion_r2035545174


More information about the net-dev mailing list