RFR: 8353013: java.net.URI.create(String) may have low performance to scan the host/domain name from URI string when the hostname starts with number [v2]

Rohitash duke at openjdk.org
Mon Apr 14 16:37:44 UTC 2025


On Mon, 14 Apr 2025 12:12:21 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Rohitash has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add benchmark
>>  - Address PR comments
>
> test/jdk/java/net/URI/Test.java line 1809:
> 
>> 1807:         testCreate("https://123.example.com").s("https").h("123.example.com").p("").z();
>> 1808:         testCreate("https://1234.example.com").s("https").h("1234.example.com").p("").z();
>> 1809:         testCreate("https://12345.example.com").s("https").h("12345.example.com").p("").z();
> 
> can we add some URIs similar to the offending URI here? Something like: 
> 
> https://98765432101.www.example.com/ and "https://9223372036854775808.www.example.com/"

Thanks! I have added more examples.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24295#discussion_r2042506649


More information about the net-dev mailing list