Integrated: 8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN

Volkan Yazici vyazici at openjdk.org
Mon Apr 14 19:18:51 UTC 2025


On Thu, 13 Mar 2025 13:34:04 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

> Fixes endian handling `jdk.internal.net.http.websocket.Frame.Masker`.
> 
> ### Implementation notes
> 
> I deleted the `Frame` clone in tests, and rewired the test code depending on it to the actual `Frame`. To enable this, I relaxed the visibility of the actual `Frame`. I guess the `Frame` clone was introduced to have strict visibility in the actual `Frame`. Though this is not needed since the actual `Frame` is in an internal package. Plus, the fact that bug is in the `Frame` class hints in the direction that there should be one `Frame`.

This pull request has now been integrated.

Changeset: f6d8c8cb
Author:    Volkan Yazici <vyazici at openjdk.org>
Committer: Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f6d8c8cb0c6b226d68791ffd126908d3fea11473
Stats:     943 lines in 11 files changed: 288 ins; 584 del; 71 mod

8351339: WebSocket::sendBinary assume that user supplied buffers are BIG_ENDIAN

Reviewed-by: michaelm, dfuchs

-------------

PR: https://git.openjdk.org/jdk/pull/24033


More information about the net-dev mailing list